Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tagging button for cloud object store containers. #2237

Merged

Conversation

martinpovolny
Copy link

Fix "Tag" button for Object store container.

https://bugzilla.redhat.com/show_bug.cgi?id=1494344

Steps to Reproduce:

  1. Add cloud provider first (Openstack RHOS7-GA recommended)
  2. Navigate to Compute -> Cloud -> Tenants
  3. Click on 'admin' from 'Cloud Tenants' table
  4. Click on 'Cloud Object Store Containers' from 'Relationship' table
  5. Click on one 'Cloud Object Store Containers' from 'All Images' table
  6. From 'Policy' select 'Edit tag'

ping @tzumainn, @petrblaho, @aufi : please, review.

@miq-bot
Copy link
Member

miq-bot commented Sep 26, 2017

Checked commit martinpovolny@ae3e02f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@aufi
Copy link
Member

aufi commented Sep 26, 2017

I believe, that Cloud Object Store belongs to Storage provider (main repo), which is mostly handled by @roliveri team. But from my point of view, looks good to me.

@dclarizio dclarizio self-assigned this Sep 26, 2017
@dclarizio dclarizio merged commit 97e5ecb into ManageIQ:master Sep 26, 2017
@dclarizio dclarizio added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants