Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tagging for generic object instances #2286

Merged

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Oct 3, 2017

Allow tagging of Generic Object instances from the details page, initially when they are shown under a GO Class (in automate) or Service.

Links

https://www.pivotaltracker.com/story/show/151174596
https://bugzilla.redhat.com/show_bug.cgi?id=1497692

screenshot from 2017-10-13 17-22-15
screenshot from 2017-10-16 00-38-29
screenshot from 2017-10-16 00-40-56
screenshot from 2017-10-16 00-41-38

@lgalis lgalis changed the title Add tagging for generic object instances [WIP]Add tagging for generic object instances Oct 3, 2017
@miq-bot miq-bot added the wip label Oct 3, 2017
@lgalis lgalis force-pushed the tagging_for_generic_object_instances branch 6 times, most recently from 0c1ba44 to c390344 Compare October 13, 2017 13:48
@lgalis lgalis force-pushed the tagging_for_generic_object_instances branch 3 times, most recently from ef9b887 to 3ef6101 Compare October 15, 2017 21:21
@lgalis lgalis force-pushed the tagging_for_generic_object_instances branch from 3ef6101 to 04c06ef Compare October 16, 2017 03:48
@miq-bot
Copy link
Member

miq-bot commented Oct 16, 2017

Checked commits lgalis/manageiq-ui-classic@a5e4fdc~...04c06ef with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
13 files checked, 7 offenses detected

app/controllers/generic_object_controller.rb

app/helpers/application_helper/toolbar/generic_object_center.rb

  • ❗ - Line 13, Col 26 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 16, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 3, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/generic_objects_center.rb

  • ❗ - Line 18, Col 29 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 21, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 3, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

@lgalis lgalis changed the title [WIP]Add tagging for generic object instances Add tagging for generic object instances Oct 16, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Oct 16, 2017

@miq-bot add_label enhancement, fine/no

@lgalis
Copy link
Contributor Author

lgalis commented Oct 16, 2017

@h-kataria -please review

@h-kataria h-kataria self-assigned this Oct 16, 2017
@h-kataria h-kataria added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 16, 2017
@h-kataria h-kataria merged commit ec534a5 into ManageIQ:master Oct 16, 2017
@lgalis lgalis deleted the tagging_for_generic_object_instances branch October 16, 2017 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants