Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FINE] Cloud Subnet issue with save button #2320

Merged
merged 2 commits into from
Nov 20, 2017
Merged

[FINE] Cloud Subnet issue with save button #2320

merged 2 commits into from
Nov 20, 2017

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Oct 8, 2017

This contains backports with 3 specific cherry-picks to address "save" button issue:

Master PR: #1545
https://bugzilla.redhat.com/show_bug.cgi?id=1467725

Requires ManageIQ/manageiq#16150 to be merged first.

@miq-bot miq-bot changed the title BZ1467725 [FINE] BZ1467725 Oct 8, 2017
@martinpovolny
Copy link
Member

@rwsu, @tzumainn, @sseago : review, please?

(then assign to @simaishi )

@tzumainn
Copy link
Contributor

I can verify this fixes the issue in conjunction with ManageIQ/manageiq#16150, so looks good to me!

@tzumainn
Copy link
Contributor

@miq-bot assign @simaishi

@gildub
Copy link
Contributor Author

gildub commented Oct 19, 2017

@simaishi, could you provide an update, thanks?

@simaishi
Copy link
Contributor

@gildub This is not a blocker for the release we're working on currently. I will merge this when we start working on the next release.

@gildub
Copy link
Contributor Author

gildub commented Oct 19, 2017

@simaishi, no hurry then, thanks.

himdel and others added 2 commits October 27, 2017 14:12
Network Provider: Cloud subnets refactor

(cherry picked from commit 69bec0a)
Instead of checking individual inputs for change check whole form for changes

(cherry picked from commit bd9d2d4)
@miq-bot
Copy link
Member

miq-bot commented Oct 27, 2017

Checked commits https://github.com/gildub/manageiq-ui-classic/compare/585d8f4630492420e0cbb90f0ebd0af3fe1073d9~...c3c79125e8cd41325eeeb678a3a5acb6a5e64637 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@aufi
Copy link
Member

aufi commented Nov 2, 2017

The BZ related to this PR has quite a high priority, can we ask for review/merge?

@simaishi
Copy link
Contributor

simaishi commented Nov 2, 2017

@gildub #1508 needs to be backported, then this PR?

This contains backports with 3 specific cherry-picks to address following issue:

Which PRs are they coming from? Please always reference the 'master' PRs.

Also, please edit the PR title to describe the issue this PR is fixing. Thanks!

@gildub
Copy link
Contributor Author

gildub commented Nov 3, 2017

@simaishi,

#1508 has been superseded by this one. So we don't need it.
The master PR is #1545.
I updated the title, more details on the linked BZ.

Thanks

@simaishi
Copy link
Contributor

simaishi commented Nov 3, 2017

@gildub I meant "[FINE] BZ1467725" by "PR title" 😄

@gildub gildub changed the title [FINE] BZ1467725 [FINE] Cloud Subnet issue with save button Nov 9, 2017
@gildub
Copy link
Contributor Author

gildub commented Nov 9, 2017

@simaishi, now I got it! ;-)

@simaishi
Copy link
Contributor

ManageIQ/manageiq#16150 is merged.

@simaishi
Copy link
Contributor

@simaishi simaishi merged commit 3610475 into ManageIQ:fine Nov 20, 2017
@simaishi simaishi added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 20, 2017
@gildub gildub deleted the BZ1467725 branch November 20, 2017 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants