Setup data for modal component #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanblanco
force-pushed
the
modal_component
branch
2 times, most recently
from
41182fb
to
bfc2a38
Compare
|
@romanblanco please update the initial comment with valid information. Thx, Dan |
|
@dclarizio updated. thanks |
romanblanco
force-pushed
the
modal_component
branch
from
0e264b1
to
f225cbb
Compare
romanblanco
force-pushed
the
modal_component
branch
3 times, most recently
from
2e5e5b2
to
4c306a7
Compare
romanblanco
changed the title
romanblanco
force-pushed
the
modal_component
branch
from
4c306a7
to
30efef0
Compare
|
Checked commits romanblanco/manageiq-ui-classic@172064e~...30efef0 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After this changes, the modal component added in ManageIQ/ui-components#177 will be used.
This change is done, so we can integrate a automate tree selector into the modal.
method
setupModalOptionssets which component with template should be rendered in the modalaccording to where the button to open modal was pressed.
Links
https://www.pivotaltracker.com/n/projects/1613907/stories/150600064
https://www.pivotaltracker.com/n/projects/1613907/stories/150614221
Steps for Testing/QA
Automation -> Automate -> Customization -> Edit Dialog in Dialog Editor -> try to open a modal