Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change decorator event names for Middleware #2331

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Change decorator event names for Middleware #2331

merged 1 commit into from
Oct 11, 2017

Conversation

tumido
Copy link
Member

@tumido tumido commented Oct 9, 2017 •
edited

Change names for Middleware events in Control->Explorer->Events

Related to: ManageIQ/manageiq-providers-hawkular#71

Before:
image
After:
image

@tumido tumido mentioned this pull request Oct 9, 2017
Merged
6 tasks
@miq-bot miq-bot added the wip label Oct 9, 2017
@tumido tumido changed the title [WIP] Change event names for Middleware Change event names for Middleware Oct 9, 2017
@tumido
Copy link
Member Author

tumido commented Oct 9, 2017

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Oct 9, 2017
@tumido
Copy link
Member Author

tumido commented Oct 9, 2017

@miq-bot add_label middleware

@tumido tumido changed the title Change event names for Middleware Change decorator event names for Middleware Oct 10, 2017
skateman
skateman approved these changes Oct 10, 2017
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miq-bot
Copy link
Member

miq-bot commented Oct 10, 2017

Checked commit tumido@701d21f with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec self-assigned this Oct 11, 2017
@mzazrivec mzazrivec added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 11, 2017
@mzazrivec mzazrivec merged commit 3da8425 into ManageIQ:master Oct 11, 2017
@tumido tumido deleted the add_middleware_op_events branch June 26, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@mzazrivec mzazrivec

Labels
middleware refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tumido @miq-bot @skateman @mzazrivec