Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud_Network: No value option for network types #2341

Merged
merged 1 commit into from Oct 11, 2017
Merged

Cloud_Network: No value option for network types #2341

merged 1 commit into from Oct 11, 2017

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Oct 11, 2017

Allows to select empty value for the provide network types. This will be aligned with default behaviour when creating network with Neutron.

Also it addresses the following bug, once backported to Fine branch:
https://bugzilla.redhat.com/show_bug.cgi?id=1490363

@miq-bot
Copy link
Member

miq-bot commented Oct 11, 2017

Checked commit https://github.com/gildub/manageiq-ui-classic/commit/755fba3a8f791b26770c5095618b910ab3bfda12 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec self-assigned this Oct 11, 2017
@mzazrivec mzazrivec added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 11, 2017
@mzazrivec mzazrivec merged commit fd7c2f8 into ManageIQ:master Oct 11, 2017
simaishi pushed a commit that referenced this pull request Nov 14, 2017
Cloud_Network: No value option for network types
(cherry picked from commit fd7c2f8)

https://bugzilla.redhat.com/show_bug.cgi?id=1512756
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 4fe1724672e344b32e1cc0c3f00ca220f811cfe7
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed Oct 11 10:01:21 2017 +0200

    Merge pull request #2341 from gildub/BZ1490363
    
    Cloud_Network: No value option for network types
    (cherry picked from commit fd7c2f878e1e289b3750529b7a2f11e72e29b080)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1512756

@gildub gildub deleted the BZ1490363 branch November 20, 2017 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants