Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show subnets dropdown for SCVMM provisioning #2373

Merged
merged 1 commit into from Oct 30, 2017
Merged

Show subnets dropdown for SCVMM provisioning #2373

merged 1 commit into from Oct 30, 2017

Conversation

agrare
Copy link
Member

@agrare agrare commented Oct 12, 2017 •
edited by chessbyte

@agrare agrare changed the title Show subnets dropdown for SCVMM provisioning [WIP] Show subnets dropdown for SCVMM provisioning Oct 12, 2017
@miq-bot miq-bot added the wip label Oct 12, 2017
@bronaghs
Copy link

hey @agrare - Can you insert a screenshot?

@agrare
Copy link
Member Author

agrare commented Oct 12, 2017

hey @agrare - Can you insert a screenshot?

👍 Added

@bronaghs
Copy link

@agrare - Thanks.
So is the vLAN on the provisioning dialog actually the VMNetwork? If so, should we re-name that field to something less confusing?

@agrare
Copy link
Member Author

agrare commented Oct 12, 2017

@bronaghs so that includes both LogicalNetworks and VMNetworks, what I am planning on doing is setting the name to something like name = vlan.parent.nil? vlan.name : "#{vlan.parent.name} / #{vlan.name}"

@agrare
Copy link
Member Author

agrare commented Oct 12, 2017

As I understand it (@djberg96 correct me if I am wrong) both LogicalNetworks and VMNetworks are valid selections for SCVMM.

@agrare agrare force-pushed the scvmm_subnet_provisioning branch 3 times, most recently from 05b3011 to f725158 Compare October 26, 2017 19:31
@agrare agrare changed the title [WIP] Show subnets dropdown for SCVMM provisioning Show subnets dropdown for SCVMM provisioning Oct 30, 2017
@agrare
Copy link
Member Author

agrare commented Oct 30, 2017

@martinpovolny @skateman can you take a look?

@miq-bot
Copy link
Member

miq-bot commented Oct 30, 2017

Checked commit agrare@715fafa with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@skateman
Copy link
Member

@agrare can you please retest after a rebase? I'm having a descendant_loader issue when trying to start rails.

@agrare
Copy link
Member Author

agrare commented Oct 30, 2017

@skateman hm works fine for me with ManageIQ/master@8bfbcc7c

screenshot from 2017-10-30 12-01-27

skateman
skateman approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@martinpovolny martinpovolny merged commit 29e1cf1 into ManageIQ:master Oct 30, 2017
@martinpovolny martinpovolny added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 30, 2017
@agrare agrare deleted the scvmm_subnet_provisioning branch October 30, 2017 18:17
@agrare
Copy link
Member Author

agrare commented Oct 30, 2017

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@martinpovolny martinpovolny

Labels
compute/infrastructure enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@agrare @bronaghs @miq-bot @skateman @martinpovolny @chessbyte