Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dialog for provisioning physical servers #2401

Merged
merged 2 commits into from Nov 3, 2017

Conversation

skovic
Copy link

@skovic skovic commented Oct 13, 2017

This PR creates a dialog for provisioning physical servers. Provisioning servers can be done by selecting and applying a LXCA config pattern to a server or group of servers. Note: Currently, the dialog is not fully functional; it only displays the servers and available configuration patterns. The rest of the functionality will be delivered in a future PR.

Depends on ManageIQ/manageiq#16203

image

image

@skovic
Copy link
Author

skovic commented Oct 13, 2017

@miq-bot add_label wip

@miq-bot miq-bot changed the title Create dialog for provisioning physical servers [WIP] Create dialog for provisioning physical servers Oct 13, 2017
@miq-bot miq-bot added the wip label Oct 13, 2017
@skovic
Copy link
Author

skovic commented Oct 16, 2017

The backend work to create the workflow for this dialog is in ManageIQ/manageiq#16203

@miq-bot
Copy link
Member

miq-bot commented Oct 16, 2017

@skovic Cannot apply the following label because they are not recognized: providers/physical

@skovic
Copy link
Author

skovic commented Oct 16, 2017

@miq-bot add_label compute/physical infrastructure

@skovic
Copy link
Author

skovic commented Oct 16, 2017

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Create dialog for provisioning physical servers Create dialog for provisioning physical servers Oct 16, 2017
@miq-bot miq-bot removed the wip label Oct 16, 2017
@skovic
Copy link
Author

skovic commented Oct 16, 2017

@agrare

@agrare
Copy link
Member

agrare commented Oct 17, 2017

@miq-bot assign @dclarizio

@gmcculloug
Copy link
Member

@skovic Can you please add Depends on ManageIQ/manageiq#16203 in the description under the text. I find it easy for a merger to miss when it is down in the comments.

@miq-bot
Copy link
Member

miq-bot commented Oct 31, 2017

This pull request is not mergeable. Please rebase and repush.

@agrare
Copy link
Member

agrare commented Oct 31, 2017

@miq-bot remove-label pending core

@miq-bot
Copy link
Member

miq-bot commented Oct 31, 2017

Checked commits skovic/manageiq-ui-classic@a1ca989~...47d3ab0 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 3 offenses detected

app/controllers/application_controller/miq_request_methods.rb

app/views/miq_request/_prov_physical_server_dialog.html.haml

  • ⚠️ - Line 10 - Line is too long. [250/160]
  • ⚠️ - Line 52 - Line is too long. [214/160]

@skovic
Copy link
Author

skovic commented Oct 31, 2017

@blomquisg @agrare Rebased the PR, but the Travis tests are still waiting to be queued.

@rodneyhbrown7
Copy link

@miq-bot add_label gaprindashvili/yes

@h-kataria h-kataria added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 3, 2017
@h-kataria h-kataria merged commit 8532241 into ManageIQ:master Nov 3, 2017
simaishi pushed a commit that referenced this pull request Nov 7, 2017
Create dialog for provisioning physical servers
(cherry picked from commit 8532241)
@simaishi
Copy link
Contributor

simaishi commented Nov 7, 2017

Gaprindashvili backport details:

$ git log -1
commit de8f211386037360aa2f81a1d05186475c47c7c2
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Fri Nov 3 17:52:10 2017 -0400

    Merge pull request #2401 from skovic/physical-server-prov-dialog
    
    Create dialog for provisioning physical servers
    (cherry picked from commit 85322417c97bfd84393c4659d75df6b8ef2d69cb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants