Display Generic Object Associations correctly #2420
Conversation
and create setup `options[:associations]` to be consumed by `nested_display_list` and `report_data`
|
Checked commits AparnaKarve/manageiq-ui-classic@4bb33fb~...338fa01 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/generic_object_controller.rb
spec/controllers/generic_object_controller_spec.rb
|
|
@AparnaKarve : is this still needed? |
|
@martinpovolny I will find out today |
|
@martinpovolny I have created a new PR - #2596 As far as the GTL related code goes, the only change that had to be retained from this PR, was the dynamic creation of |
| options[:association] = HAS_ASSOCATION[params[:model]] | ||
| elsif options[:parent].kind_of?(GenericObject) | ||
| options.merge!(generate_options(params[:model])) | ||
| end |
There was a problem hiding this comment.
I don't understand why this is needed. All options that are given to the GTL component are passwed throught to the /report_data.
Meaning we should not need to add any new exceptions here.
Actually I plan to remove the remaning exceptions and generalize this path.
Why don't you pass all the necessary options when rendering the grid?
There was a problem hiding this comment.
btw: even if we wanted to add th the exception here, I already wrote that generate_options is far too generic name in the context of the HUGE ApplicationController.
|
@martinpovolny I'm closing this in favor of #2596 |
The prior implementation of displaying GO Associations assumed that the Association name would be based off a valid model. For e.g.
servicesorvms.This assumption should not be made with Generic Objects since the association name could pretty much be anything.
The screenshot below displays a nested list of GO associations of type
'cp'(short for Cloud Providers)(I have purposely used a non-standard Association name to demonstrate that this fix can display a GO association with any name)
The nested display list url generated in this case would be -
http://localhost:3000/generic_object/show/10000000000003?display=cphttps://bugzilla.redhat.com/show_bug.cgi?id=1500829