Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix report schedule deletion #2425

Merged
merged 1 commit into from Oct 26, 2017
Merged

Fix report schedule deletion #2425

merged 1 commit into from Oct 26, 2017

Conversation

mzazrivec
Copy link
Contributor

  1. Cloud Intel -> Reports -> Schedules
  2. Verify that schedule deletion works correctly from both the list view & the schedule summary screen

https://bugzilla.redhat.com/show_bug.cgi?id=1501107

romanblanco
romanblanco approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, fixes the issue 👍

@miq-bot
Copy link
Member

miq-bot commented Oct 20, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Oct 23, 2017

Checked commit mzazrivec@53fb0eb with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@romanblanco
Copy link
Member

@mzazrivec Travis is failing, can you restart it?

@mzazrivec
Copy link
Contributor Author

@romanblanco The CI failure doesn't seem to be a temporary issue, nor it seems to be caused by this PR.

@martinpovolny martinpovolny added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 26, 2017
@martinpovolny martinpovolny merged commit b0693f1 into ManageIQ:master Oct 26, 2017
@bmclaughlin
Copy link
Contributor

@mzazrivec, any particular reason this has the fine/no flag? This appears to resolve https://bugzilla.redhat.com/show_bug.cgi?id=1477901 when cherry-picked to fine.

@mzazrivec
Copy link
Contributor Author

@bmclaughlin added fine/yes

simaishi pushed a commit that referenced this pull request Jan 10, 2018
@simaishi
Merge pull request #2425 from mzazrivec/fix_report_schedule_deletion
f45bf68 
Fix report schedule deletion
(cherry picked from commit b0693f1)

https://bugzilla.redhat.com/show_bug.cgi?id=1531262
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit f45bf684700b1c3be4978174978d20ed69c37734
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Thu Oct 26 20:30:09 2017 +0200

    Merge pull request #2425 from mzazrivec/fix_report_schedule_deletion
    
    Fix report schedule deletion
    (cherry picked from commit b0693f12a339c5fa2764c3f1429f3f1a7c483d78)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1531262

@mzazrivec mzazrivec deleted the fix_report_schedule_deletion branch February 22, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanblanco romanblanco romanblanco approved these changes

Assignees

@martinpovolny martinpovolny

Labels
bug fine/backported overview/reporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mzazrivec @miq-bot @romanblanco @bmclaughlin @simaishi @martinpovolny