Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification type error should be rendered in patternfly as danger #2426

Merged
merged 1 commit into from Oct 17, 2017

Conversation

skateman
Copy link
Member

The notification backend operates with the levels success, error, warning and info, however, PatternFly has success, danger, warning and info. We missed this inconsistency earlier so all the notifications with error levels appeared without the appropriate styling. I added a function in the frontend that converts the error to a danger so PatternFly will understand it.

Before:
screenshot from 2017-10-17 15-39-28

After:
screenshot from 2017-10-17 15-35-20

Testing:

Notification.create(:type => :automate_user_error, :initiator => User.first, :options => { :message => 'hello' })

https://bugzilla.redhat.com/show_bug.cgi?id=1489798

@miq-bot add_label bug, fine/yes

@miq-bot
Copy link
Member

miq-bot commented Oct 17, 2017

Checked commit skateman@57c2527 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@himdel himdel self-assigned this Oct 17, 2017
@himdel himdel added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 17, 2017
@himdel himdel merged commit e0b0998 into ManageIQ:master Oct 17, 2017
@skateman skateman deleted the error-danger-notifications branch October 17, 2017 15:57
simaishi pushed a commit that referenced this pull request Nov 20, 2017
Notification type error should be rendered in patternfly as danger
(cherry picked from commit e0b0998)

https://bugzilla.redhat.com/show_bug.cgi?id=1503611
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 28af21bc3770628afdb90cac9ab3390ce3c4e5f5
Author: Martin Hradil <himdel@seznam.cz>
Date:   Tue Oct 17 15:27:21 2017 +0000

    Merge pull request #2426 from skateman/error-danger-notifications
    
    Notification type error should be rendered in patternfly as danger
    (cherry picked from commit e0b0998ea2411981252b0a39d18ad498f5de345f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1503611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants