New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "Docker Labels" to "Image Labels" #2461
Change "Docker Labels" to "Image Labels" #2461
Conversation
@miq-bot add_label compute/containers, chargeback @simon3z @ilackarms @moolitayer @enoodle @zeari @himdel @yaacov please review |
@elad661 Cannot apply the following label because they are not recognized: chargeback |
Checked commit https://github.com/elad661/manageiq-ui-classic/commit/a791455aa30cf2b6798eee25d03ccd8a2f2fc149 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :+1
Makes sense, not all containers are docker containers :). Merging when green 👍 @elad661 just a note since you're new here ... maybe the PR is not important enough to warrant forcing 7 different people to look at it. In the future, please pick just one or two people :) (or you don't really have to, people look at PRs even when not pinged). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yaacov Shame on you then ;). I'm not complaining much, just something to keep in mind :) (+ I'm considering automating dropping such notifications for practical reasons :).) Anyway.. merged :) |
Description
Change all "Docker Labels" strings to "Image Labels" in the ManageIQ UI.
cloud intel -> chargeback -> assignments -> compute -> labeled container images
before:
after:
compute -> containers -> container images -> click on one of the images
before:
after: