Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Docker Labels" to "Image Labels" #2461

Merged
merged 1 commit into from Oct 19, 2017
Merged

Change "Docker Labels" to "Image Labels" #2461

merged 1 commit into from Oct 19, 2017

Conversation

elad661
Copy link
Contributor

@elad661 elad661 commented Oct 19, 2017

Description
Change all "Docker Labels" strings to "Image Labels" in the ManageIQ UI.

cloud intel -> chargeback -> assignments -> compute -> labeled container images

before:
before2

after:
after2

compute -> containers -> container images -> click on one of the images

before:
before1

after:

after1

@elad661
Copy link
Contributor Author

elad661 commented Oct 19, 2017

@miq-bot add_label compute/containers, chargeback

@simon3z @ilackarms @moolitayer @enoodle @zeari @himdel @yaacov please review

@miq-bot
Copy link
Member

miq-bot commented Oct 19, 2017

@elad661 Cannot apply the following label because they are not recognized: chargeback

@miq-bot
Copy link
Member

miq-bot commented Oct 19, 2017

Checked commit https://github.com/elad661/manageiq-ui-classic/commit/a791455aa30cf2b6798eee25d03ccd8a2f2fc149 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

Copy link

@zeari zeari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :+1

@himdel
Copy link
Contributor

himdel commented Oct 19, 2017

Makes sense, not all containers are docker containers :).

Merging when green 👍

@elad661 just a note since you're new here ... maybe the PR is not important enough to warrant forcing 7 different people to look at it. In the future, please pick just one or two people :) (or you don't really have to, people look at PRs even when not pinged).

@himdel himdel self-assigned this Oct 19, 2017
@yaacov
Copy link
Member

yaacov commented Oct 19, 2017

maybe the PR is not important enough to warrant forcing 7 different people to look at it.

@himdel , I told @elad661 to spam everybody ...

Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@himdel
Copy link
Contributor

himdel commented Oct 19, 2017

@yaacov Shame on you then ;).

I'm not complaining much, just something to keep in mind :) (+ I'm considering automating dropping such notifications for practical reasons :).)

Anyway.. merged :)

@himdel himdel merged commit 85869ec into ManageIQ:master Oct 19, 2017
@chessbyte chessbyte added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants