Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cut-off dropdowns on Set Ownership screen #2526

Merged
merged 1 commit into from Oct 27, 2017
Merged

Fix cut-off dropdowns on Set Ownership screen #2526

merged 1 commit into from Oct 27, 2017

Conversation

epwinchell
Copy link
Contributor

This PR fixes a problem where the bootstrap-select dropdowns were conflicting with the GTL #main_div by setting the data-container to "body."

https://bugzilla.redhat.com/show_bug.cgi?id=1500689

Before
screen shot 2017-10-26 at 3 28 49 pm

After
screen shot 2017-10-26 at 3 28 16 pm

@epwinchell
Copy link
Contributor Author

@miq-bot add_label fine/no, bug, formatting/styling

@miq-bot
Copy link
Member

miq-bot commented Oct 26, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/ce38042f93d319c36b84f81589992631b0ce22cc with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec self-assigned this Oct 27, 2017
@mzazrivec mzazrivec added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 27, 2017
@mzazrivec mzazrivec merged commit 0c8c62c into ManageIQ:master Oct 27, 2017
@epwinchell epwinchell deleted the 500689 branch March 20, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants