Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional playbook automate method parameters #2527

Merged
merged 1 commit into from Oct 27, 2017
Merged

Add additional playbook automate method parameters #2527

merged 1 commit into from Oct 27, 2017

Conversation

mzazrivec
Copy link
Contributor

This pull request implements the following new playbook automate method parameters:

  • Hosts
  • Execution TTL
  • Log Output

playbook-method

@h-kataria

@mzazrivec
Add additional playbook automate method parameters
75ef859 
New parameters:
* Hosts
* Execution TTL
* Log Output
@miq-bot
Copy link
Member

miq-bot commented Oct 26, 2017

Checked commit mzazrivec@75ef859 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks fine. 🍰

@h-kataria
Copy link
Contributor

@tinaafitz @mkanoor can you please test.

@h-kataria
Copy link
Contributor

@mzazrivec with changes in this PR i see Hosts field type updated on Playbook type Catalog Item editor as well, it used to be a textbox field in Catalogs Items editor.

@tinaafitz please review both Method editor & Catalog Items editor screens when testing/verifying changes. Thanks.

@mzazrivec
Copy link
Contributor Author

@h-kataria Yes, the Hosts field changed for both catalog item & automate method (as that's how
the template is designed, correct?) though that's very much intentional. You can choose either
localhost or specify host (or hosts) explicitly. Obviously, I can revert it back, though I'd like for
both forms to look the same (unless it's not what we want).

@tinaafitz
Copy link
Member

@mzazrivec @h-kataria Tested UI changes for playbook method and Service catalog item and it looks good.

@h-kataria h-kataria self-assigned this Oct 27, 2017
@h-kataria h-kataria added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 27, 2017
@h-kataria h-kataria merged commit c8411c3 into ManageIQ:master Oct 27, 2017
@mzazrivec mzazrivec deleted the add_additional_playbook_automation_method_parameters branch February 22, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
automation/automate enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mzazrivec @miq-bot @h-kataria @tinaafitz