Add fallback hostname form input fields for Nuage Network Provider #2531
Conversation
gasper-vrhovsek
force-pushed
the
feature/nuage-events-ui
branch
2 times, most recently
from
7473645
to
d604f8f
Compare
|
This PR is related to the Nuage provider PR and is required to allow adding 1 AMQP endpoint or three (1 main + two fallback); two endpoints are never used by this network provider. /cc @chargio, @blomquisg |
|
@miq-bot add_label networks |
gasper-vrhovsek
force-pushed
the
feature/nuage-events-ui
branch
from
d604f8f
to
8f1f94a
Compare
|
@miq-bot assign @AparnaKarve |
|
This pull request is not mergeable. Please rebase and repush. |
Added two fallback fields in add and edit network provider forms in case a Nuage network provider is being added.
gberginc
force-pushed
the
feature/nuage-events-ui
branch
from
8f1f94a
to
829d3a9
Compare
|
Checked commit gasper-vrhovsek@829d3a9 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@AparnaKarve I've rebased this PR to include the changes introduced recently. The backend PR is not yet merged, however it was already reviewed and got LGTM (ManageIQ/manageiq-providers-nuage#30). |
|
@gberginc, @AparnaKarve: backend PR is merged ManageIQ/manageiq-providers-nuage#30 |
|
Thanks @blomquisg!!! @AparnaKarve, if you have any questions, please reach out to me on Gitter so that I can provide responses quicker. |
| %div{"ng-if" => (defined?(hostname_hide) ? false : true) && (defined?(fallback_hostnames) ? fallback_hostnames : false)} | ||
| .form-group{"ng-class" => "{'has-error': angularForm.#{prefix}_fallback_hostname1.$invalid}"} | ||
| %label.col-md-2.control-label{"for" => "#{prefix}_fallback_hostname1"} | ||
| = _('Fallback Hostname 1') |
There was a problem hiding this comment.
Can this be 'Fallback AMQP Hostname 1'? (Same for 'Fallback Hostname 2' below).
There was a problem hiding this comment.
Thanks @blomquisg. As discussed in gitter, the reason for Fallback Hostname 1 was because this is already on the AMQP tab and the main input field is entitled Hostname.
The reason for adding the hostname, ipv4 or ipv6 as a placeholder text is that with this long name, the field label is broken into two rows which looks ugly.
|
I did not get a chance to test this in the UI, but overall the code looks good since it follows an existing pattern. LGTM |
|
Thanks @AparnaKarve and @h-kataria! |
Added two fallback fields in add and edit network provider forms in
case a Nuage network provider is being added.
@miq-bot add_label enhancement