Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display nested Resource Pools in summary page #255

Merged
merged 1 commit into from Feb 20, 2017

Conversation

jzigmund
Copy link

We want to display nested Resource pool(s) in parent summary screen.

@h-kataria
Copy link
Contributor

@jzigmund can you add screenshots for changes in this PR.

@jzigmund
Copy link
Author

@h-kataria yea I forgot that reviewer needs to have nested Resource Pools (RP) in DB.

Summary screen (with added RP to list navigation and textual summary screen):
screenshot from 2017-01-27 14-01-37

Screen after click on listnav link or textual summary to display nested RP(s):
screenshot from 2017-01-27 14-02-30

Screen of selected nested RP:
screenshot from 2017-01-27 14-02-19

@h-kataria
Copy link
Contributor

@dclarizio should we open a BZ and back-port this back to EUWE, this functionality was lost after Graphical summary screens were removed from product.

@dclarizio
Copy link

@dclarizio should we open a BZ and back-port this back to EUWE, this functionality was lost after Graphical summary screens were removed from product.

Please do, thx

@miq-bot
Copy link
Member

miq-bot commented Feb 10, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Feb 16, 2017

Checked commit jzigmund@23d55da with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 1 offense detected

app/helpers/resource_pool_helper/textual_summary.rb

@jzigmund
Copy link
Author

jzigmund commented Feb 16, 2017

@dclarizio @h-kataria
Rebased PR, created BZ (for master [cfme-future] and euwe [5.7.z]), updated commit message with the BZ link (master one).

@martinpovolny
Copy link

martinpovolny commented Feb 20, 2017

Restarted travis. @jzigmund : it you have your PR red and believe that it's not your fault, you can close and reopen the PR or ask someone for help on gitter.

@jzigmund jzigmund closed this Feb 20, 2017
@jzigmund jzigmund reopened this Feb 20, 2017
@h-kataria
Copy link
Contributor

looks good.

@h-kataria h-kataria added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 20, 2017
@h-kataria h-kataria merged commit 136c052 into ManageIQ:master Feb 20, 2017
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2017

Euwe backport (to manageiq repo) details:

$ git log -1
commit 47af4fa6d47f4262b0d0fd499ab7ced8a5f999cc
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Mon Feb 20 22:57:06 2017 +0530

    Merge pull request #255 from jzigmund/nested_resource_pools
    
    Display nested Resource Pools in summary page
    (cherry picked from commit 136c052394bd39aa66ce70d8f3f77e64e34f0f38)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1422975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants