Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken refresh functionality on all topology screens #2557

Merged
merged 1 commit into from Oct 31, 2017
Merged

Fixed broken refresh functionality on all topology screens #2557

merged 1 commit into from Oct 31, 2017

Conversation

skateman
Copy link
Member

The regression was created by one of @Hyperkid123's topology refactoring PR that made the refresh a bit too specific. The fix for now is just a simple copy-paste but it should be addressed later.

@miq-bot add_label bug

https://bugzilla.redhat.com/show_bug.cgi?id=1501048

@miq-bot miq-bot added the bug label Oct 30, 2017
@miq-bot
Copy link
Member

miq-bot commented Oct 30, 2017

Checked commit skateman@db8a1f1 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@chessbyte chessbyte closed this Oct 31, 2017
@chessbyte chessbyte reopened this Oct 31, 2017
@mzazrivec mzazrivec added this to the Sprint 73 Ending Nov 13, 2017 milestone Oct 31, 2017
@mzazrivec mzazrivec merged commit f372776 into ManageIQ:master Oct 31, 2017
@skateman skateman deleted the fix-topology-refresh branch October 31, 2017 10:04
@himdel
Copy link
Contributor

himdel commented Oct 31, 2017 •
edited

@Hyperkid123 the code should live in topologyService .. and sending just name now is wrong, we do want that controller in there.. so this should be controller: 'topologyService', name: 'refreshTopology'.

@Hyperkid123
Copy link
Contributor

I will fix it as soon as i can

simaishi pushed a commit that referenced this pull request Nov 6, 2017
@mzazrivec @simaishi
Merge pull request #2557 from skateman/fix-topology-refresh
520f3b8 
Fixed broken refresh functionality on all topology screens
(cherry picked from commit f372776)

https://bugzilla.redhat.com/show_bug.cgi?id=1509301
@simaishi
Copy link
Contributor

simaishi commented Nov 6, 2017

Gaprindashvili backport details:

$ git log -1
commit 520f3b8b94a4c9f259830ba214b200504d8530de
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Oct 31 10:40:03 2017 +0100

    Merge pull request #2557 from skateman/fix-topology-refresh
    
    Fixed broken refresh functionality on all topology screens
    (cherry picked from commit f372776c3f135ba2e2d9ea1706a6373f80f04267)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1509301

@Hyperkid123 Hyperkid123 mentioned this pull request Nov 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
bug gaprindashvili/backported topology
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@skateman @miq-bot @himdel @Hyperkid123 @simaishi @martinpovolny @chessbyte @mzazrivec