Fix buttons AND, OR, NOT, REMOVE in exp editor #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing ManageIQ/manageiq#13262 Change _exp_editor.html.haml to make buttons and, or, not, remove clickable in expression editor and use patternfly icons for buttons where it is possible instead of using png images and reach styling of buttons we need.
fixing ManageIQ/manageiq#13262 Fix bug in exp_token_pressed method to make the buttons work properly.
|
Checked commits hstastna/manageiq-ui-classic@66cbb08~...b687397 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing ManageIQ/manageiq#13262
Change _exp_editor.html.haml to make buttons and, or, not, remove
clickable in expression editor and use patternfly icons for buttons
where it is possible instead of using png images and reach
styling of buttons we need.
Fix bug in exp_token_pressed method to make the buttons work properly.
The buttons were broken by ManageIQ/manageiq#12975