Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable assign of policy profiles #2595

Merged
merged 2 commits into from Nov 5, 2017

Conversation

karelhala
Copy link
Contributor

@karelhala karelhala commented Nov 1, 2017

This PR:

  • enables to assign policies to selected MW servers or one server

New screen with policy assign

screenshot from 2017-11-01 18-15-20

Pending core

@karelhala
Copy link
Contributor Author

@miq-bot add_label enhancement, middleware, pending core, wip

@abonas
Copy link
Member

abonas commented Nov 2, 2017

@miq-bot add_label gaprindashvili/yes

@abonas
Copy link
Member

abonas commented Nov 2, 2017

is this ready for review? it's marked as wip

@karelhala
Copy link
Contributor Author

@abonas we need to merge ManageIQ/manageiq#16375 and #2594 first to make it work

@karelhala karelhala closed this Nov 2, 2017
@karelhala karelhala reopened this Nov 2, 2017
@karelhala karelhala changed the title [WIP] Enable assign of policy profiles Enable assign of policy profiles Nov 2, 2017
@karelhala
Copy link
Contributor Author

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Nov 2, 2017
@abonas
Copy link
Member

abonas commented Nov 2, 2017

@abonas we need to merge ManageIQ/manageiq#16375 and #2594 first to make it work

yes that is clear. however typically PRs in wip tend to get less attention

@abonas
Copy link
Member

abonas commented Nov 2, 2017

@miq-bot add_label control

@miq-bot miq-bot added the control label Nov 2, 2017
@abonas
Copy link
Member

abonas commented Nov 2, 2017

@aljesusg please review

@aljesusg
Copy link
Member

aljesusg commented Nov 2, 2017

Maybe is a good idea set in description like a tasks lists that depends of another PR

Depends

@miq-bot
Copy link
Member

miq-bot commented Nov 3, 2017

Checked commits karelhala/manageiq-ui-classic@85c68ee~...14daf64 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 4 offenses detected

app/helpers/application_helper/toolbar/middleware_server_center.rb

app/helpers/application_helper/toolbar/middleware_servers_center.rb

@abonas
Copy link
Member

abonas commented Nov 5, 2017

@miq-bot assign @martinpovolny

@abonas
Copy link
Member

abonas commented Nov 5, 2017

@martinpovolny seems ready to be merged

@martinpovolny martinpovolny merged commit 8f2b93a into ManageIQ:master Nov 5, 2017
@martinpovolny martinpovolny added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 5, 2017
simaishi pushed a commit that referenced this pull request Nov 7, 2017
Enable assign of policy profiles
(cherry picked from commit 8f2b93a)
@simaishi
Copy link
Contributor

simaishi commented Nov 7, 2017

Gaprindashvili backport details:

$ git log -1
commit ae68dc9ce4b3645d09dfd04c90a7850f01ac7ac2
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Sun Nov 5 18:32:18 2017 +0100

    Merge pull request #2595 from karelhala/mwPoliciesAssign
    
    Enable assign of policy profiles
    (cherry picked from commit 8f2b93a74be9184506072f162f768371460a1067)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants