Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GAPRINDASHVILI] Update ui-components to 1.0.0, semver #2624

Merged
merged 2 commits into from Nov 3, 2017
Merged

[GAPRINDASHVILI] Update ui-components to 1.0.0, semver #2624

merged 2 commits into from Nov 3, 2017

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Nov 3, 2017 •
edited

This..

  • adds bower-locker as a npm dependency, so that anyone can run it when necessary
  • updates the unlocked bower.json to depend on manageiq-ui-components ~1.0.0
  • locks to the newly released 1.0.0

After this is merged, the process for updating manageiq-ui-components for gaprindashvili fixes should be pretty much just this (details):

yarn run bower-locker unlock
bower install manageiq-ui-components
yarn run bower-locker lock

@miq-bot
Copy link
Member

miq-bot commented Nov 3, 2017

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/12d09f9430523f2b46b3dab578dff1f4142091ae~...7982d2646534df35e19b84ba2f2f6def8b1f5beb with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@simaishi simaishi merged commit 4033aa6 into ManageIQ:gaprindashvili Nov 3, 2017
@simaishi simaishi added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 3, 2017
@himdel himdel deleted the gapri-ui-components branch November 3, 2017 18:24
@himdel himdel mentioned this pull request Nov 3, 2017
Merged
@himdel himdel mentioned this pull request Oct 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy approved these changes

Assignees

@simaishi simaishi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@himdel @miq-bot @Fryguy @simaishi