Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Network Adapters table to Network Devices #2627

Merged
merged 1 commit into from Nov 7, 2017
Merged

Rename Network Adapters table to Network Devices #2627

merged 1 commit into from Nov 7, 2017

Conversation

skovic
Copy link

@skovic skovic commented Nov 3, 2017

This PR renames the Network Adapters table on the physical server summary page to Network Devices.

@skovic skovic changed the title Rename Network Adapter table to Network Devices Rename Network Adapters table to Network Devices Nov 3, 2017
@miq-bot
Copy link
Member

miq-bot commented Nov 3, 2017

Checked commit skovic@5a424c8 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@skovic
Copy link
Author

skovic commented Nov 3, 2017

@miq-bot add_label gaprindashvili/yes

@skovic
Copy link
Author

skovic commented Nov 3, 2017

@miq-bot add_label compute/physical infrastructure

@skovic
Copy link
Author

skovic commented Nov 3, 2017

@agrare

@mzazrivec mzazrivec added the bug label Nov 7, 2017
@mzazrivec mzazrivec self-assigned this Nov 7, 2017
@mzazrivec mzazrivec added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 7, 2017
@mzazrivec mzazrivec merged commit a1b7e8d into ManageIQ:master Nov 7, 2017
simaishi pushed a commit that referenced this pull request Nov 7, 2017
@mzazrivec @simaishi
Merge pull request #2627 from skovic/rename-network-adapter-table
adb49b4 
Rename Network Adapters table to Network Devices
(cherry picked from commit a1b7e8d)
@simaishi
Copy link
Contributor

simaishi commented Nov 7, 2017

Gaprindashvili backport details:

$ git log -1
commit adb49b4ed7b6cb50c27b306aeef466baf95fa762
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Nov 7 11:04:28 2017 +0100

    Merge pull request #2627 from skovic/rename-network-adapter-table
    
    Rename Network Adapters table to Network Devices
    (cherry picked from commit a1b7e8d5b8701c48842f1992acd469441602bb1a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug compute/physical infrastructure gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skovic @miq-bot @simaishi @mzazrivec