Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional options to report_data for tagging and other functions which use get_db_view instead of get_view #2667

Merged

Conversation

karelhala
Copy link
Contributor

Fixes problem with no additional data set for some actions

When tagging, live migrating adding policies and other functions which were using get_db_view to get view without going trough more complex get_view function attribute @report_data_additional_options is set so report_data can use these additional options.

@karelhala
Copy link
Contributor Author

@miq-bot add_label bug, gaprindashvili/yes, GTLs
@martinpovolny this is the PR we were discussing before.

@miq-bot
Copy link
Member

miq-bot commented Nov 8, 2017

@karelhala Cannot apply the following label because they are not recognized: gtls

@miq-bot
Copy link
Member

miq-bot commented Nov 8, 2017

Checked commit karelhala@f26f282 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny martinpovolny merged commit 412eea0 into ManageIQ:master Nov 9, 2017
@martinpovolny martinpovolny self-assigned this Nov 9, 2017
@martinpovolny martinpovolny added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 9, 2017
simaishi pushed a commit that referenced this pull request Nov 15, 2017
Add additional options to report_data for tagging and other functions which use get_db_view instead of get_view
(cherry picked from commit 412eea0)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 94803ffc96f2759336e79fc96fbaeaee5a26a380
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Thu Nov 9 13:20:59 2017 +0100

    Merge pull request #2667 from karelhala/additionalOptionsForTagging
    
    Add additional options to report_data for tagging and other functions which use get_db_view instead of get_view
    (cherry picked from commit 412eea02514030db527a1bf44a76cad0bf35a0b2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants