Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk Name should not display 0 for unavailable Used/Provisioned size #2673

Merged

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Nov 8, 2017

Remove the Provisioned Size listed as 0.0 for Azure Containers Disk Name, as the size_on_disk is not available.

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1510177

Steps for Testing/QA

Steps to Reproduce:

  1. Add an Azure provider
  2. Select any instance
  3. Click on Containers
  4. View the details of a disk
  5. Percent Used Provisioned Space: 0.0%

Before:
screenshot from 2017-11-08 14-00-43

After:
screenshot from 2017-11-08 12-03-35

@lgalis
Copy link
Contributor Author

lgalis commented Nov 8, 2017

@dclarizio, @bronaghs - please review

  • waiting for needinfo on the BZ before removing the WIP label

@miq-bot miq-bot added the wip label Nov 8, 2017
@bronaghs
Copy link

bronaghs commented Nov 8, 2017

LGTM

@lgalis lgalis force-pushed the azure_container_disk_size_display_fix branch from 6063d70 to e7c4255 Compare November 8, 2017 19:44
@lgalis
Copy link
Contributor Author

lgalis commented Nov 8, 2017

@miq-bot add_label bug, fine/yes, gaprindashvili/yes

@lgalis lgalis force-pushed the azure_container_disk_size_display_fix branch from e7c4255 to baf246f Compare November 8, 2017 20:06
@miq-bot
Copy link
Member

miq-bot commented Nov 8, 2017

Checked commits lgalis/manageiq-ui-classic@caea881~...baf246f with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@lgalis lgalis changed the title [WIP] Disk Name should not display 0 for unavailable Used/Provisioned size Disk Name should not display 0 for unavailable Used/Provisioned size Nov 8, 2017
@miq-bot miq-bot removed the wip label Nov 8, 2017
@dclarizio dclarizio merged commit 2faeb15 into ManageIQ:master Nov 8, 2017
@dclarizio dclarizio added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 8, 2017
@lgalis lgalis deleted the azure_container_disk_size_display_fix branch November 9, 2017 13:29
simaishi pushed a commit that referenced this pull request Nov 15, 2017
…y_fix

Disk Name should not display 0 for unavailable Used/Provisioned size
(cherry picked from commit 2faeb15)

https://bugzilla.redhat.com/show_bug.cgi?id=1511978
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 9e3a0441b79e2326437e918fb4990f0eed75a964
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Wed Nov 8 14:24:52 2017 -0800

    Merge pull request #2673 from lgalis/azure_container_disk_size_display_fix
    
    Disk Name should not display 0 for unavailable Used/Provisioned size
    (cherry picked from commit 2faeb158eda6ddc5e80ac53f12352a4bf65bd009)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1511978

@simaishi
Copy link
Contributor

simaishi commented Nov 20, 2017

@lgalis This part of the code was refactored in #752 and that's not in Fine branch. Can you create a separate PR for Fine branch?

Please add #2681 to Fine PR as well, as that's a follow up for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants