New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disk Name should not display 0 for unavailable Used/Provisioned size #2673
Merged
dclarizio
merged 2 commits into
ManageIQ:master
from
lgalis:azure_container_disk_size_display_fix
Nov 8, 2017
Merged
Disk Name should not display 0 for unavailable Used/Provisioned size #2673
dclarizio
merged 2 commits into
ManageIQ:master
from
lgalis:azure_container_disk_size_display_fix
Nov 8, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dclarizio, @bronaghs - please review
|
LGTM |
lgalis
force-pushed
the
azure_container_disk_size_display_fix
branch
from
November 8, 2017 19:44
6063d70
to
e7c4255
Compare
@miq-bot add_label bug, fine/yes, gaprindashvili/yes |
lgalis
force-pushed
the
azure_container_disk_size_display_fix
branch
from
November 8, 2017 20:06
e7c4255
to
baf246f
Compare
Checked commits lgalis/manageiq-ui-classic@caea881~...baf246f with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
lgalis
changed the title
[WIP] Disk Name should not display 0 for unavailable Used/Provisioned size
Disk Name should not display 0 for unavailable Used/Provisioned size
Nov 8, 2017
simaishi
pushed a commit
that referenced
this pull request
Nov 15, 2017
…y_fix Disk Name should not display 0 for unavailable Used/Provisioned size (cherry picked from commit 2faeb15) https://bugzilla.redhat.com/show_bug.cgi?id=1511978
Gaprindashvili backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the Provisioned Size listed as 0.0 for Azure Containers Disk Name, as the size_on_disk is not available.
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1510177
Steps for Testing/QA
Steps to Reproduce:
Before:
After: