Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to show "Cloud Credentials" drop down on Retirement tab #2761

Conversation

h-kataria
Copy link
Contributor

Both Provisioning & Retirement tabs have Cloud Type drop downs. Fixed cloudTypeChanged method to use prefix variable that is being passed in to determine which cloud type drop down is being edited in UI

https://bugzilla.redhat.com/show_bug.cgi?id=1510407

@syncrou can you please test/verify. Thanks.

before after selecting Cloud type on Retirement tab, Cloud Credentials drop down was missing:
before

after:
after

Both Provisioning & Retirement tabs have Cloud Type drop downs. Fixed cloudTypeChanged method to use prefix variable that is being passed in to determine which cloud type drop down is being edited in UI

https://bugzilla.redhat.com/show_bug.cgi?id=1510407
@miq-bot
Copy link
Member

miq-bot commented Nov 17, 2017

Checked commit h-kataria@2f02964 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@dclarizio dclarizio merged commit a786a25 into ManageIQ:master Nov 17, 2017
@dclarizio dclarizio added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 17, 2017
simaishi pushed a commit that referenced this pull request Nov 20, 2017
…ils_drop_down_fix

Fix to show "Cloud Credentials" drop down on Retirement tab
(cherry picked from commit a786a25)

https://bugzilla.redhat.com/show_bug.cgi?id=1515301
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 122ceab060ffbd63eda561ee7da22d7b2bd1069e
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Fri Nov 17 14:34:27 2017 -0800

    Merge pull request #2761 from h-kataria/retirement_tab_cloud_credentails_drop_down_fix
    
    Fix to show "Cloud Credentials" drop down on Retirement tab
    (cherry picked from commit a786a251889dd7f95e00b76f1f306c3b49ddca03)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1515301

@h-kataria h-kataria deleted the retirement_tab_cloud_credentails_drop_down_fix branch December 1, 2017 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants