Favor complete ui strings over string concatenation #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzazrivec
changed the title
|
Checked commit mzazrivec@59a982d with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 app/helpers/application_helper/button/cockpit_console.rb
|
| def platform_supported?(record_type) | ||
| if record_type == 'VM' | ||
| def platform_supported? | ||
| if @record.respond_to?(:current_state) |
There was a problem hiding this comment.
this change is intended? (does not look translation related)
There was a problem hiding this comment.
Yes, intended. In the code above, the record_type argument passed in would either
be _('VM') or _('Container Node'). Now that wouldn't really work in non-English locales,
would it?
|
related to #2800 |
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
…r_string_concatenation Favor complete ui strings over string concatenation (cherry picked from commit 963dbf9)
|
Gaprindashvili backport details: |
mzazrivec
deleted the
favor_complete_ui_strings_over_string_concatenation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is addressing a concern / problem expressed by our translators.