Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for node alerts #277

Merged
merged 1 commit into from Jan 31, 2017
Merged

Add icon for node alerts #277

merged 1 commit into from Jan 31, 2017

Conversation

moolitayer
Copy link

@moolitayer moolitayer commented Jan 31, 2017

Needed for ManageIQ/manageiq#12773 in the main repo.
(can be merged safety before)

Uploading Screenshot from 2017-01-31 20-36-08.png…

@moolitayer
Copy link
Author

@epwinchell can you please review this?

@epwinchell
Copy link
Contributor

@moolitayer We're in the process of removing all PNG references. Please use:

when 'ContainerNode'
  {:icon => 'pficon pficon-container-node'}

@moolitayer
Copy link
Author

Thanks @epwinchell! fixed

@miq-bot
Copy link
Member

miq-bot commented Jan 31, 2017

Checked commit moolitayer@e4b9e66 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

@epwinchell
Copy link
Contributor

@miq-bot assign @himdel

@miq-bot miq-bot assigned himdel and unassigned epwinchell Jan 31, 2017
@himdel himdel merged commit bf941a6 into ManageIQ:master Jan 31, 2017
@himdel himdel added this to the Sprint 54 Ending Feb 13, 2017 milestone Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants