Explicitly disable broker for vSphere validation #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add-label bug, compute/infrastructure, gaprindashvili/no |
agrare
force-pushed
the
fix_vmware_infra_credential_validation
branch
from
5297e08
to
712f19b
Compare
The Vmware::InfraManager#verify_credentials method explicitly disabled broker connections when verifying credentials so that new providers aren't saved in the brokered connection list in addition to the issue that the broker will not typically be running when validating credentials for the first VMware provider. When moving to validate_credentials_task which calls raw_connect this option wasn't passed in, but we were checking for :fault_tolerant and using MiqVim instead of MiqFaultTolerantVim which implicitly doesn't use the broker so everything worked fine. In ManageIQ/manageiq-ui-classic@cf1eae9 we removed the :fault_tolerant option because it should always be enabled, the :use_broker option is intended to control if we connect to the broker or not. This however broke the implicit skip broker option that credential validation was using. This mimics the Vmware::InfraManager#verify_credentials way of explicitly disabling use of the broker by passing it as a task argument.
agrare
force-pushed
the
fix_vmware_infra_credential_validation
branch
from
712f19b
to
81306ab
Compare
|
Checked commit agrare@81306ab with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Vmware::InfraManager#verify_credentialsmethod explicitly disabledbroker connections when verifying credentials so that new providers
aren't saved in the brokered connection list in addition to the issue
that the broker will not typically be running when validating
credentials for the first VMware provider.
When moving to
.validate_credentials_taskwhich callsraw_connectthisoption wasn't passed in, but we were checking for
:fault_tolerantandusing
MiqViminstead ofMiqFaultTolerantVimwhich implicitly doesn't usethe broker so everything worked fine.
In ManageIQ/manageiq@cf1eae9 we removed the
:fault_tolerantoption because it should always beenabled, the
:use_brokeroption is intended to control if we connect tothe broker or not. This however broke the implicit skip broker option
that credential validation was using.
This mimics the
Vmware::InfraManager#verify_credentialsway ofexplicitly disabling use of the broker by passing it as a task argument.