Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ansible Tower provider node tagging to take into account the selected node model #2783

Merged

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Nov 20, 2017

Fix Ansible Tower provider node tagging to take into account the selected node model

Links [Optional]

https://bugzilla.redhat.com/show_bug.cgi?id=1510821

Steps for Testing/QA

Tagging a configured system in the Ansible Provider Manager accordion

@miq-bot miq-bot added the wip label Nov 20, 2017
@lgalis lgalis force-pushed the tagging_based_on_ansible_provider_node branch from 6ba33a7 to 43eb93b Compare November 20, 2017 22:46
@lgalis lgalis force-pushed the tagging_based_on_ansible_provider_node branch from 43eb93b to ccf89fc Compare November 20, 2017 22:54
…mary page in the ansible provider accordion

Fixed mixed lifecycle toolbars for foreman and automation
@miq-bot
Copy link
Member

miq-bot commented Nov 21, 2017

Checked commits lgalis/manageiq-ui-classic@5424741~...8e85612 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
11 files checked, 12 offenses detected

app/controllers/automation_manager_controller.rb

app/helpers/application_helper/toolbar/configured_system/automation/policy_mixin.rb

  • ❗ - Line 23, Col 6 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 4, Col 8 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/configured_system/foreman/lifecycle_mixin.rb

  • ❗ - Line 21, Col 82 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 24, Col 5 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 4, Col 7 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/configured_system/foreman/policy_mixin.rb

  • ❗ - Line 19, Col 34 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 22, Col 5 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 4, Col 7 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/x_automation_manager_ansible_tower_configured_system_center.rb

  • ❗ - Line 18, Col 32 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 21, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 3, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

@lgalis lgalis changed the title [WIP]Fix Ansible Tower provider node tagging to take into account the selected node model Fix Ansible Tower provider node tagging to take into account the selected node model Nov 21, 2017
@miq-bot miq-bot removed the wip label Nov 21, 2017
@h-kataria h-kataria added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 21, 2017
@h-kataria h-kataria merged commit 19e4158 into ManageIQ:master Nov 21, 2017
@lgalis lgalis deleted the tagging_based_on_ansible_provider_node branch November 22, 2017 04:04
simaishi pushed a commit that referenced this pull request Nov 27, 2017
…r_node

Fix Ansible Tower provider node tagging to take into account the selected node model
(cherry picked from commit 19e4158)

https://bugzilla.redhat.com/show_bug.cgi?id=1517891
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 86b0e676828683a89038a65b869fa5515474ccc5
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Tue Nov 21 18:40:36 2017 -0500

    Merge pull request #2783 from lgalis/tagging_based_on_ansible_provider_node
    
    Fix Ansible Tower provider node tagging to take into account the selected node model
    (cherry picked from commit 19e4158c2d1883a51de62bed8ebbec310eff77c4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants