GTL missing parent fix #2804
Merged
GTL missing parent fix #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpovolny
force-pushed
the
gtl_parent_fix
branch
2 times, most recently
from
7bb4146
to
7e67776
Compare
martinpovolny
force-pushed
the
gtl_parent_fix
branch
from
7e67776
to
bfbf450
Compare
Adding a missing variable omitted in ManageIQ#2727
@use_action was to handle exceptional behavior of nested list (mostly) under Hosts before the @report_data_additional_options was introduced. @use_action was set: * for all lists in HostController (via HostController.get_session_data and then * for (hosts,users,groups,patches, guest_application) in ExplorerShow.init_show_variables. ExplorerShow in included throught the ApplicationController everyhere. Some nested lists are used e.g. in VmInfraContoller (guest_application, linux_initprocesses). The whole line: :active_tree => (x_active_tree unless params[:display] || @use_action) in GtlHelper.render_gtl_outer is another candidate for removal.
martinpovolny
force-pushed
the
gtl_parent_fix
branch
from
bfbf450
to
a185e62
Compare
|
Some comments on commits martinpovolny/manageiq-ui-classic@da45f4e~...a185e62 spec/controllers/host_controller_spec.rb
|
|
Checked commits martinpovolny/manageiq-ui-classic@da45f4e~...a185e62 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM, also tested with |
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
GTL missing parent fix (cherry picked from commit c38ae77) https://bugzilla.redhat.com/show_bug.cgi?id=1517914
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1516331
Pass @parent to the rendering routine. The variable is missing since #2727
Remove @use_action (see details in the commit message).
The @use_action is set
for the whole Host controller
(HostController.get_session_data)
in init_show_variables in ExplorerShow
that is called from:
I have added some specs. And have manually tested:
host --> {users,groups,guest_application,host_services}
vm --> {guest_application,linux_initprocesses}
Have not tested "hosts" and "patches" -- don't have the data, but the pattern is the same.
I have noticed that host-->groups,guest_application has broken breadcrumb: "Services". But that is unrelated to this PR.
Ping @himdel, this needs a detailed reading, please help.
Ping @karelhala : I know you said that removing the @use_action "should be ok", but please, take a look.
Ping @alexander-demichev : this should unlock your fixing of the issue we discussed.
Testers welcome.