Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use supports_vm_import? instead of validate_import_vm #2807

Merged
merged 1 commit into from Nov 23, 2017
Merged

Use supports_vm_import? instead of validate_import_vm #2807

merged 1 commit into from Nov 23, 2017

Conversation

smelamud
Copy link
Contributor

@smelamud smelamud commented Nov 22, 2017 •
edited

@smelamud
Copy link
Contributor Author

@miq-bot assign himdel

@miq-bot
Copy link
Member

miq-bot commented Nov 22, 2017

Checked commit smelamud@0bfc865 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@himdel
Copy link
Contributor

himdel commented Nov 23, 2017 •
edited

Reassigned to @martinpovolny - ManageIQ/manageiq#16526 and this one need to be merged in sync.

(LGTM)

@himdel himdel assigned martinpovolny and unassigned himdel Nov 23, 2017
@himdel himdel mentioned this pull request Nov 23, 2017
Merged
@martinpovolny martinpovolny merged commit 108991d into ManageIQ:master Nov 23, 2017
@martinpovolny martinpovolny added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 23, 2017
@smelamud
Copy link
Contributor Author

smelamud commented Dec 5, 2017

@miq-bot add_labels gaprindashvili/yes

@miq-bot miq-bot assigned himdel and unassigned martinpovolny Dec 5, 2017
simaishi pushed a commit that referenced this pull request Dec 11, 2017
@simaishi
Merge pull request #2807 from smelamud/supports-vm-import
992f875 
Use supports_vm_import? instead of validate_import_vm
(cherry picked from commit 108991d)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 992f8751b898d972821c9701e42398e7df24a069
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Thu Nov 23 19:51:19 2017 +0100

    Merge pull request #2807 from smelamud/supports-vm-import
    
    Use supports_vm_import? instead of validate_import_vm
    (cherry picked from commit 108991d8360c5acf08d4b252545fb1a0fdff6f7d)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@himdel himdel

Labels
compute/infrastructure gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@smelamud @miq-bot @himdel @simaishi @martinpovolny @mzazrivec