Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the showtype to nil when displaying the provider list page 馃悕 #2815

Merged
merged 1 commit into from Nov 23, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Nov 23, 2017

This way the dashboard view of a provider's summary will not interfere with the provider list screen.

Before:
screenshot from 2017-11-23 18-53-36

After:
screenshot from 2017-11-23 18-52-03

https://bugzilla.redhat.com/show_bug.cgi?id=1500779

@skateman skateman changed the title Force the showtype to nil when displaying the provider list page Force the showtype to nil when displaying the provider list page 馃悕 Nov 23, 2017
@miq-bot
Copy link
Member

miq-bot commented Nov 23, 2017

Checked commit skateman@32fb5d7 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 馃嵃

@mzazrivec mzazrivec self-assigned this Nov 23, 2017
@mzazrivec mzazrivec added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 23, 2017
@mzazrivec mzazrivec merged commit 56d76ae into ManageIQ:master Nov 23, 2017
@skateman skateman deleted the provider-list-listnav branch November 23, 2017 18:48
simaishi pushed a commit that referenced this pull request Nov 27, 2017
Force the showtype to nil when displaying the provider list page 馃悕
(cherry picked from commit 56d76ae)

https://bugzilla.redhat.com/show_bug.cgi?id=1517937
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit b171949a4480969626903b0e5bfbb855ae58bfc2
Author: Milan Z谩zrivec <mzazrivec@redhat.com>
Date:   Thu Nov 23 19:36:13 2017 +0100

    Merge pull request #2815 from skateman/provider-list-listnav
    
    Force the showtype to nil when displaying the provider list page <U+1F40D>
    (cherry picked from commit 56d76aec9cddcfd745953755394d3355e541022d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants