Rename 'phase' to 'status' for container groups summary page #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeari
force-pushed
the
rename_phase_status
branch
from
63b5f0a
to
5e1419d
Compare
|
Checked commit zeari@5e1419d with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label compute/containers, gaprindashvili/yes |
mzazrivec
reviewed
Nov 27, 2017
| @@ -86,7 +86,7 @@ | |||
| %thead | |||
| %tr | |||
| %th Name | |||
| %th Phase | |||
| %th Status | |||
There was a problem hiding this comment.
This whole haml lacks gettext, fix in #2829
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
Rename 'phase' to 'status' for container groups summary page (cherry picked from commit 34d8502) https://bugzilla.redhat.com/show_bug.cgi?id=1517947
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1406741
Status is the term that appears on the provider side so theres no reason for this to be named differently.
@moolitayer @nimrodshn please review
cc @bazulay