Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Replace .success calls with .then/.catch (Round 5, final round) #284

Merged
merged 15 commits into from
Feb 6, 2017

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Feb 1, 2017

Replace .success calls in angular controllers with .then .catch
This is the final stretch of this refactoring effort (Phew!)

The following controllers have been covered here --

  • time_profile_form_controller.js
  • floating_ip_form_controller.js
  • host_aggregate_form_controller.js
  • network_router_form_controller.js
  • orchestration_template_copy_controller.js
  • ownership_form_controller.js
  • reconfigure_form_controller.js
  • retirement_form_controller.js
  • security_group_form_controller.js
  • service_form_controller.js
  • vm_cloud_associate_floating_ip_form_controller.js
  • vm_cloud_disassociate_floating_ip_form_controller.js
  • vm_cloud_evacuate_form_controller.js
  • vm_cloud_live_migrate_form_controller.js

(Round 1 -- #13
Round 2 -- #179
Round 3 -- #232
Round 4 -- #281)

@miq-bot
Copy link
Member

miq-bot commented Feb 2, 2017

Checked commits AparnaKarve/manageiq-ui-classic@061167d~...c847b85 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍪

@AparnaKarve
Copy link
Contributor Author

AparnaKarve commented Feb 2, 2017

@himdel T minus 14 controllers and we should be able to upgrade to Angular 1.6. (14 controllers in this PR, that is)

I did a quick dry run with 1.6 and tried a few of my favorite forms, and all was quiet (as in, no errors)

@himdel himdel self-assigned this Feb 6, 2017
@himdel himdel merged commit 3bf98f9 into ManageIQ:master Feb 6, 2017
@himdel himdel added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 6, 2017
@himdel
Copy link
Contributor

himdel commented Feb 6, 2017

Thanks for all the effort @AparnaKarve looks like we're finally rid of them all! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants