-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor - Replace .success calls with .then/.catch (Round 5, final round) #284
Conversation
1423d60
to
c847b85
Compare
Checked commits AparnaKarve/manageiq-ui-classic@061167d~...c847b85 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@himdel I did a quick dry run with 1.6 and tried a few of my favorite forms, and all was quiet (as in, no errors) |
Thanks for all the effort @AparnaKarve looks like we're finally rid of them all! :) |
Replace
.success
calls in angular controllers with.then
.catch
This is the final stretch of this refactoring effort (Phew!)
The following controllers have been covered here --
(Round 1 -- #13
Round 2 -- #179
Round 3 -- #232
Round 4 -- #281)