Disable buttons for adding new cloud items when no provider available 🐛

[skateman]

There were some cloud-related item buttons that were enabled even when there was no available provider for them:

• Creating a new Flavor
• Creating a new Cloud Tenant
• Creating a new Host Aggregate

These now will be disabled when there is no related provider available. Tests included to make @martinpovolny happy.

https://bugzilla.redhat.com/show_bug.cgi?id=1516877

[miq-bot]

Checked commit skateman@f270948 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
9 files checked, 4 offenses detected

app/helpers/application_helper/button/new_cloud_tenant.rb

• ❗ - Line 3, Col 14 - Style/NumericPredicate - Use ManageIQ::Providers::Openstack::CloudManager.count.zero? instead of ManageIQ::Providers::Openstack::CloudManager.count == 0.

app/helpers/application_helper/toolbar/cloud_tenants_center.rb

• ❗ - Line 14, Col 62 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/host_aggregates_center.rb

• ❗ - Line 15, Col 64 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

spec/helpers/application_helper/buttons/new_host_aggregate_spec.rb

• ⚠️ - Line 16, Col 9 - Lint/UselessAssignment - Useless assignment to variable - provider.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit d300e1194e2b5c2650a698f58b2d74621dcf7ee0
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed Nov 29 10:20:36 2017 +0100

    Merge pull request #2849 from skateman/cloud-new
    
    Disable buttons for adding new cloud items when no provider available <U+1F41B>
    (cherry picked from commit fd1d03331bb6e1b987b8adbab3e17e9c7b32a985)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1518745