Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cap & U card positioning #2868

Merged
merged 1 commit into from Nov 30, 2017
Merged

Fix Cap & U card positioning #2868

merged 1 commit into from Nov 30, 2017

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Nov 29, 2017

Add "spacer" class div to fix top margin of card area on C & U screen

Old
screen shot 2017-11-29 at 12 37 13 pm

New
screen shot 2017-11-29 at 2 30 14 pm

@epwinchell
Copy link
Contributor Author

@miq-bot add_label formatting/styling, bug

@epwinchell
Copy link
Contributor Author

cc @tumido

@miq-bot
Copy link
Member

miq-bot commented Nov 29, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/9074a372bcc9c21b90368860f0e63dd65d6645a3 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@ohadlevy
Copy link
Member

/cc @serenamarie125

@serenamarie125
Copy link

@epwinchell what are you using for spacing? I imagine that we should have the same spacing left/right spacing? currently it looks like the spacing to the left of the CPU card is much smaller than to the right.

@epwinchell
Copy link
Contributor Author

epwinchell commented Nov 29, 2017

@serenamarie125 The spacing is the same left and right - it was a clipped screenshot, which I've updated. It's the same 3-column layout and spacing as the main dashboard. The edges are narrower than in between the cards, but I'd suggest tackling all the dashboards together (separate from this PR.)

@epwinchell
Copy link
Contributor Author

@miq-bot assign @dclarizio

@serenamarie125
Copy link

thanks @epwinchell fyi - suggested spacing would be 20px, but understandable about tackling everything together

@mzazrivec mzazrivec added this to the Sprint 75 Ending Dec 11, 2017 milestone Nov 30, 2017
@mzazrivec mzazrivec merged commit d47885f into ManageIQ:master Nov 30, 2017
@mzazrivec
Copy link
Contributor

@epwinchell Is this gaprindashvili/yes ?

@epwinchell epwinchell deleted the c_and_u_styling branch March 20, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants