Update ui-components to 0.0.12 (dialog editor) #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
changed the title
|
This pull request is not mergeable. Please rebase and repush. |
adding angular-dragdrop & angular-ui-sortable and upgrading ui-components to 0.0.12 to be explicit also added a jquery conflict resolution, to prevent jquery 3 from getting installed
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/552455c4ebdadcd57087ad149bde8b99d65c26d5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
himdel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: ManageIQ/manageiq#13775
Just released
manageiq-ui-componentsversion 0.0.12, but we do have that~in the dependency, so suddenly we also need it's new dependencies.Adding angular-dragdrop & angular-ui-sortable - dependencies of the new dialog editor.
And upgrading ui-components to 0.0.12 just to be explicit.