dropdownMenu - don't use data-remote when not provided #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the link has `data-remote=""`, downloading a PDF doesn't work. (The request succeeds, the data is returned, but the browser ignores it and doesn't download.) `data-remote` is used for other things, like minimizing the dashboard. Thus, changing to use `ng-attr-data-remote`, which will do the same thing as before when the attribute value is provided, but won't add the attr when empty. https://bugzilla.redhat.com/show_bug.cgi?id=1516784
|
Note: if you're getting a As a workaround, you need to find the entry in |
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/cd2d8ef36181325972d208d1a8ae06e4c0fa9669 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Dec 1, 2017
dropdownMenu - don't use data-remote when not provided (cherry picked from commit 12422b8) https://bugzilla.redhat.com/show_bug.cgi?id=1519840
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the link has
data-remote="", downloading a PDF doesn't work. (The request succeeds, the data is returned, but the browser ignores it and doesn't download.)data-remoteis used for other things, like minimizing the dashboard.Thus, changing to use
ng-attr-data-remote, which will do the same thing as before when the attribute value is provided, but won't add the attr when empty.Cc @mzazrivec , @ZitaNemeckova
https://bugzilla.redhat.com/show_bug.cgi?id=1516784