bz 1402867: Prevent scale down in scaling UI #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzazrivec
reviewed
Dec 5, 2017
| @@ -68,6 +68,10 @@ def scaling | |||
| return_message = _("Scaling") | |||
| @count_parameters.each do |p| | |||
| if !scale_parameters[p.name].nil? && scale_parameters[p.name] != p.value | |||
| if scale_parameters[p.name].to_s < p.value.to_s | |||
| log_and_flash_message(_("Scaling down is not supported. New value for %{name} %{new_value} is lower than current value %{current_value}.") % {:name => p.name, :new_value => scale_parameters[p.name], :current_value => p.value}) | |||
There was a problem hiding this comment.
log_and_flash_message() was removed recently from our code. Now, you should just use add_flash(...)
There was a problem hiding this comment.
@mzazrivec OK I updated this to reflect the change.
https://bugzilla.redhat.com/show_bug.cgi?id=1402867 In the scaling UI, added checks to allow scaling up but not down. Scale down is handled explicitly via a separate UI action with validation around maintenance mode on the node and lack of active VMs.
sseago
force-pushed
the
validate_scale_up
branch
from
d4dd666
to
0d5216a
Compare
|
Checked commit sseago@0d5216a with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 app/controllers/ems_infra_controller.rb
|
simaishi
pushed a commit
that referenced
this pull request
Dec 8, 2017
bz 1402867: Prevent scale down in scaling UI (cherry picked from commit 7b16236) https://bugzilla.redhat.com/show_bug.cgi?id=1523855
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Dec 11, 2017
bz 1402867: Prevent scale down in scaling UI (cherry picked from commit 7b16236) https://bugzilla.redhat.com/show_bug.cgi?id=1524653
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1402867
In the scaling UI, added checks to allow scaling up but not down.
Scale down is handled explicitly via a separate UI action with
validation around maintenance mode on the node and lack of active
VMs.