Fix for storages under storage pods #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 30, 2017 22:23
Selected records should be passed to get_view only when records cannot be specified using associations or named scopes. Furthemore this imperfect implementation was broken in during the GTL conversion.
|
Some comments on commits martinpovolny/manageiq-ui-classic@d1a383c~...d000d5f spec/controllers/storage_controller_spec.rb
|
|
Checked commits martinpovolny/manageiq-ui-classic@d1a383c~...d000d5f with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/controllers/storage_controller_spec.rb
|
martinpovolny
changed the title
simaishi
pushed a commit
that referenced
this pull request
Dec 4, 2017
Fix for storages under storage pods (cherry picked from commit fd1faec) https://bugzilla.redhat.com/show_bug.cgi?id=1520530
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected records should be passed to get_view only when records cannot be specified using associations or named scopes.
Furthemore this imperfect implementation was broken in during the GTL conversion.
https://bugzilla.redhat.com/show_bug.cgi?id=1501063
Ping @lgalis, @tumido : please, review