Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provisioning form: "logical_cpus" is called "cpu_total_cores". #2914

Merged
merged 1 commit into from Dec 4, 2017
Merged

Provisioning form: "logical_cpus" is called "cpu_total_cores". #2914

merged 1 commit into from Dec 4, 2017

Conversation

martinpovolny
Copy link

Testing

  1. Go to Compute->Infrastructure->Virtual Machines
  2. From Lifecycle-> VM Provision
  3. Sort templates by CPUs
  4. Observe that sorting does (not) work

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1501053

@miq-bot
Copy link
Member

miq-bot commented Dec 3, 2017

Checked commit martinpovolny@6c728c5 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Dec 4, 2017
@mzazrivec mzazrivec added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 4, 2017
@mzazrivec mzazrivec merged commit 83256fc into ManageIQ:master Dec 4, 2017
simaishi pushed a commit that referenced this pull request Dec 4, 2017
@mzazrivec @simaishi
Merge pull request #2914 from martinpovolny/provision_sorting_cpus
bb9177c 
Provisioning form: "logical_cpus" is called "cpu_total_cores".
(cherry picked from commit 83256fc)

https://bugzilla.redhat.com/show_bug.cgi?id=1520529
@simaishi
Copy link
Contributor

simaishi commented Dec 4, 2017

Gaprindashvili backport details:

$ git log -1
commit bb9177c1df3efcd18167878d0b6d5f10ff323123
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Dec 4 09:16:00 2017 +0100

    Merge pull request #2914 from martinpovolny/provision_sorting_cpus
    
    Provisioning form: "logical_cpus" is called "cpu_total_cores".
    (cherry picked from commit 83256fcb0bab3308292bb8193e50c145fe06cd8b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug compute/infrastructure gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@martinpovolny @miq-bot @simaishi @mzazrivec