handle nil values in dashbaord trend data #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zeari Cannot apply the following label because they are not recognized: providers/containers |
|
@miq-bot add_label compute/containers |
zeari
force-pushed
the
handle_more_nils
branch
from
fdd97c5
to
2f664e3
Compare
zeari
force-pushed
the
handle_more_nils
branch
from
2f664e3
to
03213db
Compare
|
Checked commit zeari@03213db with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM, merging when green :) |
simaishi
pushed a commit
that referenced
this pull request
Dec 4, 2017
handle nil values in dashbaord trend data (cherry picked from commit a0acd4a)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1519530solved by #2762followup to #2762
EDIT: This doesnt solve the BZ but it still makes the code a little safer
@himdel Please review
@miq-bot add_label bug, providers/containers