Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken containers link in container dashboard #2919

Merged
merged 1 commit into from Dec 4, 2017
Merged

Fix broken containers link in container dashboard #2919

merged 1 commit into from Dec 4, 2017

Conversation

nimrodshn
Copy link
Contributor

Containers link is broken when state is nill - this patch fixes this behavior.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1519382
cc: @himdel

@nimrodshn
fix container link on dashboard bug
989c0bb 
minor refactoring

minor refactoring

minor refactoring
@miq-bot
Copy link
Member

miq-bot commented Dec 4, 2017

Checked commit nimrodshn@989c0bb with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@nimrodshn
Copy link
Contributor Author

@miq-bot add_label bug, gaprindashvili/yes

yaacov
yaacov approved these changes Dec 4, 2017
View reviewed changes
Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

i like better, but your way is ok too.
row[col] ? row[col].titleize : ''

@himdel himdel self-assigned this Dec 4, 2017
@himdel himdel merged commit d549f6a into ManageIQ:master Dec 4, 2017
@himdel himdel added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 4, 2017
simaishi pushed a commit that referenced this pull request Dec 4, 2017
@himdel @simaishi
Merge pull request #2919 from nimrodshn/fix_titelize_broken_link
e7f6642 
Fix broken containers link in container dashboard
(cherry picked from commit d549f6a)

https://bugzilla.redhat.com/show_bug.cgi?id=1520618
@simaishi
Copy link
Contributor

simaishi commented Dec 4, 2017

Gaprindashvili backport details:

$ git log -1
commit e7f6642602f7cf1429448bca86497c7262216c1f
Author: Martin Hradil <himdel@seznam.cz>
Date:   Mon Dec 4 19:54:42 2017 +0000

    Merge pull request #2919 from nimrodshn/fix_titelize_broken_link
    
    Fix broken containers link in container dashboard
    (cherry picked from commit d549f6acc4e22c9d7ecb8f0f6585cf25caa036e2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaacov yaacov yaacov approved these changes

Assignees

@himdel himdel

Labels
bug compute/containers gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nimrodshn @miq-bot @simaishi @yaacov @himdel