Fix export button in widget export screen #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rubocop issues seem releavant. I don't ask you to write a test that there are not 2 export buttons on the screen, but can you add some trivial test ensuring that the page renders ok? Thx! |
mzazrivec
force-pushed
the
fix_export_button_in_widget_export
branch
from
7394b6d
to
add540f
Compare
|
Test is coming ... |
|
@martinpovolny tests added. |
|
Checked commits mzazrivec/manageiq-ui-classic@add540f~...bef7c77 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Dec 11, 2017
…xport Fix export button in widget export screen (cherry picked from commit ba4d75f) https://bugzilla.redhat.com/show_bug.cgi?id=1524639
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go to: Cloud Intel -> Reports -> Import/Export -> Widgets. Make sure the export button is not duplicated and that the export button works correctly.
https://bugzilla.redhat.com/show_bug.cgi?id=1518945