Update toolbar icons

[epwinchell]

Replacing remaining power state images with font icons; update other font icons to latest Patternfly. (Depends of upgrade to Patternfly Sass 3.23.1)

Before (Host - Power)

After (Host - Power)

Before (VM - Power)

After (VM - Power)

Before (Instance - Power)

After (Instance - Power)

Before (Physical Server - Power)

After (Physical Server - Power)

Before (Physical Server - Identify)

After (Physical Server - Identify)

Before (Middleware Server - Power)

After (Middleware Server - Power)

[epwinchell]

@miq-bot add_label graphics, enhancement

[serenamarie125]

Looking forward to seeing this. @epwinchell please tag me once you get the screenshots

[epwinchell]

@serenamarie125 Screenshots posted

[epwinchell]

@miq-bot add_label ux/review

[epwinchell]

@serenamarie125 I had to do some guess work because the status/action pairs here: https://www.patternfly.org/styles/icons/ are incomplete. Also, no mention of things like fa-play that were covered in our original google doc.

I think a comprehensive mapping of actions and icons would be really helpful.
Also, "pficon-paused" is surrounded by a circle.. fa-stop isn't.. so should i use "fa-stop-circle-o"? same question for play, etc.

[serenamarie125]

@epwinchell will look into this with Jenny on Mon/Tue to see if we can help fill the gaps!

[serenamarie125]

@epwinchell, note that the convention that's being used is that if a status has a corresponding status, we are using the icon inside a circle for the status. Given that:

• suspend should use fa-pause
• I have questions on Shelve & what that specifically does, as well as
• Reset - wondering if using fa-refresh as you are currently doing makes sense. And if so, if we should just use that label?

[epwinchell]

@dclarizio Can you chime in?

I have questions on Shelve & what that specifically does, as well as
Reset - wondering if using fa-refresh as you are currently doing makes sense. And if so, if we should just use that label?

[dclarizio]

@serenamarie125

I have questions on Shelve & what that specifically does, as well as

I have no idea what Shelve is, sorry

Reset - wondering if using fa-refresh as you are currently doing makes sense. And if so, if we should just use that label?

All I know is reset != refresh, so we can't call it that. In addition, the Reset button on most physical computers looks like the Restart image shown above, but without the little clock hands inside (in case we want to take a clue from the real world).

[epwinchell]

@serenamarie125 Are these helpful?

https://stackbees.com/index.php/2015/11/30/what-is-shelving/ and

https://ask.openstack.org/en/question/32000/whats-the-difference-between-shelving-vs-shutting-down-an-instance/

[epwinchell]

ping @serenamarie125

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[serenamarie125]

@epwinchell so is shelving new functionality? I don't see it in the old screenshots.

We are using fa-camera 📷for snapshot, but shelving seems more complicated than that 🤔

[epwinchell]

@serenamarie125 It's not new... but the "before" screenshot is missing. I'll add it tomorrow.

[epwinchell]

@serenamarie125 I added the "before" screenshot. Also, I posted some links earlier describing shelving. Thanks.

[epwinchell]

@miq-bot add_label gaprindashvili/no

[epwinchell]

@miq-bot rm_label unmergeable

[serenamarie125]

@miq-bot add_labels ux/approved
@miq-bot remove_labels ux/review

[serenamarie125]

I think we are good to go for now. I agree with the approach you've taken - use the equivalent icons :)

[epwinchell]

@miq-bot assign @himdel

[epwinchell]

@miq-bot assign @dclarizio

[miq-bot]

Checked commits https://github.com/epwinchell/manageiq-ui-classic/compare/538407236a646a4d79753157cbfe01deb9354806~...05cc67d8c35f5d0b99cec0ed1350ff80f514b1f7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
13 files checked, 0 offenses detected
Everything looks fine. 👍