Changed CSS class for button #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit romanblanco@c584ff6 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@romanblanco Looks good |
|
@mzazrivec Can you merge, please? |
|
/cc @serenamarie125 |
|
LGTM, consistency++ - primary buttons need to use |
|
@miq-bot set_milestone Sprint 76 Ending Dec 18, 2017 (because it doesn't exist yet) |
|
@himdel Milestone Sprint 76 Ending Dec 18, 2017 is not recognized, ignoring... |
|
@ohadlevy Should we really ping the UX team just for such small and obvious changes? /cc @serenamarie125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed CSS class for Import button, so both the buttons with action (Import / Export) are consistent:
Before:
After:
Steps for Testing/QA
Automate → Automation → Customization → Import/Export accordion
cc/ @epwinchell