Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreman fixes #2949

Merged
merged 4 commits into from Dec 6, 2017
Merged

Foreman fixes #2949

merged 4 commits into from Dec 6, 2017

Conversation

martinpovolny
Copy link

please read the commit messages

partial fix for: #2927

@martinpovolny martinpovolny changed the title [WIP] Foreman fixes Foreman fixes Dec 5, 2017
@martinpovolny martinpovolny removed the wip label Dec 5, 2017
@miq-bot
Copy link
Member

miq-bot commented Dec 5, 2017

Checked commits martinpovolny/manageiq-ui-classic@5e3e1a8~...4821d09 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

lgalis
lgalis reviewed Dec 6, 2017
View reviewed changes
Copy link
Contributor

@lgalis lgalis left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, verified that the tile and grid views display the icons for Configuration Providers and Configured Systems.
The changes to display quadicons for the ConfigurationProfiles to follow.

@mzazrivec mzazrivec added the bug label Dec 6, 2017
@mzazrivec mzazrivec self-assigned this Dec 6, 2017
@mzazrivec mzazrivec added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 6, 2017
@mzazrivec mzazrivec merged commit 0165bae into ManageIQ:master Dec 6, 2017
simaishi pushed a commit that referenced this pull request Dec 11, 2017
@mzazrivec @simaishi
Merge pull request #2949 from martinpovolny/foreman_fixes
c2a0e6d 
Foreman fixes
(cherry picked from commit 0165bae)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit c2a0e6d387e3456a838947404a4e45132762886d
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed Dec 6 10:40:38 2017 +0100

    Merge pull request #2949 from martinpovolny/foreman_fixes
    
    Foreman fixes
    (cherry picked from commit 0165bae1a706c496187f3a184c700d19e701aa57)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgalis lgalis lgalis left review comments

Assignees

@mzazrivec mzazrivec

Labels
bug configuration management gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@martinpovolny @miq-bot @simaishi @lgalis @mzazrivec