Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GenericObject to APPLIES_TO_CLASS_BASE_MODEL #2973

Merged
merged 1 commit into from Dec 6, 2017
Merged

Add GenericObject to APPLIES_TO_CLASS_BASE_MODEL #2973

merged 1 commit into from Dec 6, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Dec 6, 2017

Add GenericObject to APPLIES_TO_CLASS_BASE_MODEL

  • fixes an error that occurs for custom buttons created in the customization->Buttons for generic objects

Before:
screenshot from 2017-12-06 17-40-10

After
screenshot from 2017-12-06 17-39-06

@lgalis
Copy link
Contributor Author

lgalis commented Dec 6, 2017

@dclarizio - please review ( as discussed via email)

@miq-bot - add_label wip, gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Dec 6, 2017

@lgalis unrecognized command '-', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@dclarizio dclarizio self-assigned this Dec 6, 2017
@miq-bot
Copy link
Member

miq-bot commented Dec 6, 2017

Checked commit lgalis@feba095 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@dclarizio dclarizio merged commit cff1101 into ManageIQ:master Dec 6, 2017
@dclarizio dclarizio added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 6, 2017
@lgalis lgalis deleted the add_generic_object_instance_to_base_models_list branch December 6, 2017 23:48
simaishi pushed a commit that referenced this pull request Dec 11, 2017
@simaishi
Merge pull request #2973 from lgalis/add_generic_object_instance_to_b…
34192df 
…ase_models_list

Add GenericObject to APPLIES_TO_CLASS_BASE_MODEL
(cherry picked from commit cff1101)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 34192df51640383f16e0239dad6d5a1d33eba5a3
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Wed Dec 6 15:11:22 2017 -0800

    Merge pull request #2973 from lgalis/add_generic_object_instance_to_base_models_list
    
    Add GenericObject to APPLIES_TO_CLASS_BASE_MODEL
    (cherry picked from commit cff11015005a97f062e7122e906542a6d52c3231)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
bug gaprindashvili/backported generic objects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lgalis @miq-bot @simaishi @dclarizio