Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes to show Cloud credentials on service summary screen #3057

Merged
merged 1 commit into from Dec 13, 2017

Conversation

h-kataria
Copy link
Contributor

  • And made all credentials values as clickable links.
  • Removed VMware Credentials code, as those fall under Cloud Credentials, dont need to show them separately.

https://bugzilla.redhat.com/show_bug.cgi?id=1515561

before:
before

after:
after

- And made all credentials values as clickable links.
- Removed VMware Credentials code, as those fall under Cloud Credentials, dont need to show them separately.

https://bugzilla.redhat.com/show_bug.cgi?id=1515561
@miq-bot
Copy link
Member

miq-bot commented Dec 13, 2017

Checked commit h-kataria@f93b03c with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@dclarizio dclarizio merged commit ce629dd into ManageIQ:master Dec 13, 2017
@dclarizio dclarizio added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 13, 2017
simaishi pushed a commit that referenced this pull request Dec 14, 2017
Made changes to show Cloud credentials on service summary screen
(cherry picked from commit ce629dd)

https://bugzilla.redhat.com/show_bug.cgi?id=1526081
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 84185bafe902ea24f463e2234fa9df0bc5d4a1a9
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Wed Dec 13 14:38:10 2017 -0800

    Merge pull request #3057 from h-kataria/cloud_credential_display_fix
    
    Made changes to show Cloud credentials on service summary screen
    (cherry picked from commit ce629dddf63dc5301dd1b2453f85fc2c9ecad86d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1526081

@h-kataria h-kataria deleted the cloud_credential_display_fix branch January 12, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants