Fixes All Policy Profiles page header text #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
reviewed
Dec 14, 2017
| @@ -560,7 +560,7 @@ def replace_right_cell(options = {}) | |||
| end | |||
|
|
|||
| presenter.update(:main_div, r[:partial => partial_name]) | |||
| right_cell_text = _("All %{models}") % {:models => model} | |||
There was a problem hiding this comment.
@GregP i think we should just change https://github.com/GregP/manageiq-ui-classic/blob/28ff2b3b5628e99b8aecfb1c120151eab63b98e4/app/controllers/miq_policy_controller.rb#L553-L554 to have pluralized values, and skip ui_lookup call
GregP
force-pushed
the
all_policy_profiles_header
branch
from
28ff2b3
to
933392d
Compare
|
Checked commit GregP@933392d with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Dec 15, 2017
Fixes All Policy Profiles page header text (cherry picked from commit d4e9e12) https://bugzilla.redhat.com/show_bug.cgi?id=1526590
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code to use plural forms.
https://bugzilla.redhat.com/show_bug.cgi?id=1508902
Screen shot prior to code fix:
Screen shot post code fix:
