Display the correct report title on full screen widget screens #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@059fc2c with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Dec 19, 2017
Display the correct report title on full screen widget screens (cherry picked from commit c5974e5) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527580
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When displaying a dashboard widget in a new window (full screen option in its kebab), the title was set by the
@layoutinstance variable. Instead of this it should set to@report.title, so changing it.TODO: it would be better to move out this
report_onlycondition from theapplication.html.hamland create a new layout. It would ease testing and maintainability.@miq-bot add_label bug, gaprindashvili/yes, cloud intel/dashboard
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1526302